Skip to content

Permission check - #4146

Merged
LKuemmel merged 4 commits into
openWB:masterfrom
benderl:permission-check
Oct 20, 2026
Merged

LKuemmel merged 4 commits into
openWB:masterfrom
benderl:permission-check

Conversation

@benderl

@benderl benderl commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

check mosquitto ACLs against settings views
UI: openWB/openwb-ui-settings#1134

@benderl benderl added this to the 2.3.0 milestone Oct 20, 2026
@benderl benderl self-assigned this Oct 20, 2026
@benderl benderl added the ui depends on changes in ui repository label Oct 20, 2026
@benderl
benderl requested a review from LKuemmel October 20, 2026 12:04
@LKuemmel
LKuemmel requested a lite review from Copilot October 20, 2026 12:18
@@ -81,2405 +81,2485 @@
"anonymousGroup": "anonymous",
"roles": [
{
"rolename": "openwb-version:11",
"rolename": "openwb-version:13",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum wird die 12 übersprungen?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich musste ein Rebase wegen der PV-Prognose machen. Dabei hatte ich nicht gesehen, dass dort anscheinend die Version nicht hochgezählt wurde. War mir durchgegangen.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Upgraded installations need an explicit group-membership migration for the new permissions.

No open issues 🎉

What changed in this PR

Updates Mosquitto ACL roles and group permissions to align with settings views and MQTT topics.

Changes:

  • Reorganizes resource-specific ACL templates.
  • Updates roles, groups, and permissions.
  • Bumps the ACL configuration version to 13.
File Summary
data/​config/​mosquitto/​public/​role-templates.json Updates per-resource MQTT permission templates.
data/​config/​mosquitto/​public/​default-dynamic-security.json Revises default groups, roles, and ACL mappings.

Review effort: Lite

@LKuemmel

Copy link
Copy Markdown
Contributor

The PR adds ACLs to existing roles; it does not introduce new role assignments. update_acls() already adds missing ACLs when the security version changes, preserving existing user/group assignments. Therefore, no additional group-membership migration is needed for these changes.

@LKuemmel
LKuemmel merged commit 4b8b682 into openWB:master Oct 20, 2026
1 check passed
@benderl
benderl deleted the permission-check branch October 22, 2026 07:24
LKuemmel pushed a commit that referenced this pull request Oct 22, 2026
* sort roles and acls

* add missing permissions

* increase security version

* add ForecastConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui depends on changes in ui repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants