Repository navigation
Feature: local_power pro counter - #4120
Merged
LKuemmel merged 2 commits intoOct 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Counters outside the grid-counter subtree retain zero or stale local-power values.
1 open finding
What changed in this PR
Adds per-counter local_power values to the control model and MQTT handling.
Changes:
- Stores calculated local power during home-consumption processing.
- Adds the counter field, MQTT validation, and configuration topic entry.
| File | Description |
|---|---|
| packages/helpermodules/update_config.py | Adds the local-power topic pattern. |
| packages/helpermodules/setdata.py | Validates local-power values as floats. |
| packages/control/counter.py | Defines the local-power field. |
| packages/control/counter_all/counter_all.py | Stores calculated local power per visited counter. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| home_consumption = 0.0 | ||
| not_home_consumption = 0.0 | ||
| local_power = self._get_local_power_from_counter(element) | ||
| data.data.counter_data[f"counter{element['id']}"].data.get.local_power = local_power |
AlexanderHa98
requested review from
LKuemmel
and
a balanced review from Copilot
October 15, 2026 07:40
LKuemmel
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.