Repository navigation
Peak Filter: add missing peak filters - #4109
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Tesla Powerwall 3/fallback counter path bypasses the new peak filtering.
1 open finding
What changed in this PR
Adds missing peak filtering for energy and power values across Tesla, SolarEdge, SMA, and Fronius modules.
Changes:
- Integrates
PeakFilterinto Tesla inverter, counter, and battery handling. - Filters SolarEdge and Fronius inverter exports.
- Filters parsed SMA states.
- Updates SolarEdge tests.
| File | Description |
|---|---|
packages/modules/devices/tesla/tesla/inverter.py |
Filters Tesla inverter values |
packages/modules/devices/tesla/tesla/counter.py |
Filters Tesla counter values |
packages/modules/devices/tesla/tesla/bat.py |
Filters Tesla battery values |
packages/modules/devices/solaredge/solaredge/inverter.py |
Filters SolarEdge exports |
packages/modules/devices/solaredge/solaredge/inverter_test.py |
Tests filter integration |
packages/modules/devices/sma/sma_shm/utils.py |
Filters SMA parsed states |
packages/modules/devices/fronius/fronius_sunspec/inverter.py |
Filters Fronius exports |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+49
to
+50
| state.imported, state.exported = self.peak_filter.check_values( | ||
| state.power, state.imported, state.exported) |
Comment on lines
+24
to
+25
| imported, exported = self.peak_filter.check_values( | ||
| power, aggregate["battery"]["energy_imported"], aggregate["battery"]["energy_exported"]) |
ndrsnhs
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references #3908 (comment)