Repository navigation
Small Fix: Hausverbrauchszähler - #4092
Merged
LKuemmel merged 2 commits intoOct 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The newly supported nested hybrid-counter scenario lacks regression coverage.
1 open finding
What changed in this PR
Extends home-consumption calculation to account for hybrid batteries beneath nested counters.
Changes:
- Refreshes downstream elements during each counter recursion.
- Includes directly attached hybrid batteries at every hierarchy level.
| File | Description |
|---|---|
packages/control/counter_all/counter_all.py |
Adds recursive downstream-element resolution. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if child["type"] == ComponentType.COUNTER.value: | ||
| # Die Funktion muss in jedem Rekursionsschritt ausgeführt werden, da die Funktion nur | ||
| # Hybrid-Batterien berücksichtigt, wenn diese direkt unter dem aktuellen Zähler hängen | ||
| child["children"] = self.get_elements_for_downstream_calculation(child["id"]) |
LKuemmel
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.