Repository navigation
Consumer: fix update values extra meters, on time counter for not controlled - #4081
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Current calculation can overwrite measurements or fail on zero voltage, and some linked meters may be finalized after their consumers.
3 open findings
What changed in this PR
This PR updates consumer value handling so uncontrolled consumers track on-time, and schedules extra meters for value updates.
Changes:
- Adds linked extra meters that are absent from the hierarchy to the update sequence.
- Moves consumer current, charge-state, and on-time calculations before the uncontrolled-consumer return.
| File | Description |
|---|---|
packages/modules/loadvars.py |
Adds extra meters to the update levels. |
packages/control/consumer/consumer.py |
Updates consumer state and on-time before the early return. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| continue | ||
| if extra_meter_id in known_counter_ids: | ||
| continue | ||
| extra_meter_level.append({"type": ComponentType.COUNTER.value, "id": extra_meter_id}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references #3908 (reply in thread)