Repository navigation
Verbraucher: remove legacy code, improve error handling - #4070
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the exclusion can double-count linked counters and breaks the existing test.
1 open finding
What changed in this PR
Removes legacy extra-meter filtering from consumer counter aggregation.
Changes:
- Deletes assigned extra-meter detection.
- Stops skipping linked counters during calculations.
| File | Description |
|---|---|
packages/modules/common/store/_counter.py |
Removes legacy extra-meter counter handling. |
🧠 Review effort: Lite
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two moderate error-handling issues remain unresolved.
3 open findings
1 resolved since last review
🧠 Review effort: Lite
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Comment on lines
+57
to
+60
| except ValueError: | ||
| raise Exception( | ||
| f"Zähler {extra_meter_id} für die separate Lesitungsmessung von Verbraucher " | ||
| f"{get_consumer_name_by_id(self.delegate.delegate.num)} ist im Fehlerzustand oder gelöscht worden.") |
Comment on lines
+42
to
+44
| for consumer in data.data.consumer_data.values(): | ||
| if consumer.module.config.id == id: | ||
| return consumer.module.config.name |
| )) | ||
| except ValueError: | ||
| raise Exception( | ||
| f"Zähler {extra_meter_id} für die separate Lesitungsmessung von Verbraucher " |
LKuemmel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.