Repository navigation
Verbraucher: min Betriebsstrom auf minimale Leistung ändern - #4061
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates consumer minimum operating thresholds from current-based to power-based configuration, preserving existing settings through datastore migration.
Changes:
- Adds datastore version 154 migration.
- Converts minimum power to current at runtime.
- Updates defaults and related tests.
| File | Description |
|---|---|
packages/helpermodules/update_config.py |
Adds datastore migration. |
packages/helpermodules/update_config_test.py |
Tests migration behavior. |
packages/control/consumer/consumer.py |
Converts minimum power to current. |
packages/control/consumer/consumer_test.py |
Updates consumer threshold tests. |
packages/control/consumer/consumer_data.py |
Replaces min_current with min_power. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
@LKuemmel kurzer Hinweis: upgrade_datastore_154 berechnet min_power unverrundet aus min_current * phasen * 230 (zB 0,5A * 1 * 230 = 115), das neue Eingabefeld erlaubt aber nur Vielfache von 10 und markiert 115 dauerhaft als ungültig. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openWB/openwb-ui-settings#1118