Skip to content

fix consumer: my-pv ACThor/Elwa-E #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LKuemmel merged 2 commits into from
Oct 7, 2026
Merged

fix consumer: my-pv ACThor/Elwa-E #4051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6dbb3a
my-pv ACThor/Elwa-E: write_register statt nicht existierendem write_r…
seaspotter Oct 4, 2026
073303b
Refactor write_registers calls to use Register
seaspotter Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions docs/samples/sample_consumer/sample_consumer/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,23 +57,28 @@ def update() -> ConsumerState:
# ConsumerUsage.SUSPENDABLE_TUNABLE
def set_power_limit(power_limit: float, data: SetLimitData) -> None:
nonlocal client
client.write_registers(1000, power_limit, unit=config.configuration.modbus_id)
client.write_register(Register.1000, int(power_limit), data_type=ModbusDataType.INT_16,
unit=config.configuration.modbus_id)

# ODER
# ConsumerUsage.SUSPENDABLE_ONOFF
# ConsumerUsage.CONTINUOUS
def switch_on() -> None:
nonlocal client
client.write_registers(1000, 1, unit=config.configuration.modbus_id)
client.write_register(Register.1000, 1, data_type=ModbusDataType.INT_16,
unit=config.configuration.modbus_id)

def switch_off() -> None:
nonlocal client
client.write_registers(1000, 0, unit=config.configuration.modbus_id)
client.write_register(Register.1000, 0, data_type=ModbusDataType.INT_16,
unit=config.configuration.modbus_id)

# ODER
# ConsumerUsage.SELF_CONTROLLED
def send_values(values: CurrentValues) -> None:
client.write_registers(1000, values.evu_power, unit=config.configuration.modbus_id)
nonlocal client
client.write_register(Register.1000, int(values.evu_power), data_type=ModbusDataType.INT_16,
unit=config.configuration.modbus_id)

return ConfigurableConsumer(consumer_config=config,
initializer=initializer,
Expand Down
3 changes: 2 additions & 1 deletion packages/modules/consumers/my_pv/acthor/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ def update() -> ConsumerState:

def set_power_limit(power_limit: float, data: SetLimitData) -> None:
power_limit = power_limit * FACTORS.get(config.configuration.model, 9000)/config.configuration.max_power
client.write_registers(1000, power_limit, unit=config.configuration.modbus_id)
client.write_register(1000, int(power_limit), data_type=ModbusDataType.INT_16,
unit=config.configuration.modbus_id)
return ConfigurableConsumer(consumer_config=config,
initializer=initializer,
error_handler=error_handler,
Expand Down
3 changes: 2 additions & 1 deletion packages/modules/consumers/my_pv/elwa_e/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ def set_power_limit(power_limit: float, data: SetLimitData) -> None:
power_limit = min(power_limit, 4000)
power_limit = max(power_limit, 0)

client.write_registers(1000, power_limit, unit=config.configuration.modbus_id)
client.write_register(1000, int(power_limit), data_type=ModbusDataType.INT_16,
unit=config.configuration.modbus_id)
return ConfigurableConsumer(consumer_config=config,
initializer=initializer,
error_handler=error_handler,
Expand Down
Loading