Repository navigation
Koala connection warning - #4044
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The dialog duration is incorrect, and independently arriving security topics can cause a spurious login dialog.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds a staged MQTT connection warning and improves security-topic handling in the Koala theme.
Changes:
- Shows connecting and disconnected states after configurable delays.
- Re-evaluates login visibility when security topics arrive.
- Defaults user management to inactive until its retained value arrives.
| File | Description |
|---|---|
ConnectionIndicator.vue |
Adds delayed connection-state dialogs and indicators. |
UserIndicator.vue |
Reacts to both security settings. |
mqtt-store.ts |
Removes the optimistic user-management default. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+382
to
+388
| watch( | ||
| [userManagementActive, anonymousAccessAllowed], | ||
| () => { | ||
| showLoginDialog.value = | ||
| userManagementActive.value && | ||
| !anonymousAccessAllowed.value && | ||
| !loggedIn.value; |
benderl
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falls der Verbindungsaufbau länger dauert, wird anstelle der roten Fehlermeldung „Verbindung getrennt!“ ein Informationsdialog "Verbindung wird aufgebaut " mit einer Sanduhr for 10 Sekunden angezeigt.
danach kommt die Fehlermeldung "Verbindung getrennt!" falls eine Verbindung immer noch nicht vorhanden ist.