Repository navigation
force_soc_update: keinen Retry-Loop bei dauerhaft veraltetem EV-SoC - #4036
Merged
Merged
Conversation
LKuemmel
requested changes
Oct 14, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two moderate issues remain involving duplicate updates and unsupported metadata topics.
2 open findings
What changed in this PR
This PR prevents repeated stale EV SoC updates and preserves existing SoC values when fresh data is unavailable.
Changes:
- Tracks force-update requests by CP timestamp and EV.
- Skips publishing
NoneSoC values. - Adds force-update tracking state.
| File | Summary |
|---|---|
packages/modules/common/store/_chargepoint.py |
Preserves SoC values when incoming data is missing. |
packages/control/chargepoint/chargepoint.py |
Suppresses repeated force-update requests. |
packages/control/chargepoint/chargepoint_data.py |
Adds force-update tracking fields. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ltes Pub bei EV-Wechsel vermeiden
LKuemmel
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

cp.soc_timestamp > ev.soc_timestamplösteforce_soc_updatebisher jeden Zyklus neu aus, nicht nur beim Wechsel wie die beiden anderen Bedingungen daneben. Bleibt der EV-seitige SoC dauerhaft veraltet (zB API-Fehler, Tageslimit erschöpft), entsteht daraus ein Retry-Loop, der das konfigurierte Intervall umgeht und selbst das Limit weiter befeuert.soc/soc_timestampwurden beim Publish nie aufNonegeprüft, anders alsimported/exported/plug_state/rfid/phases_in_usein derselben Methode. Ohne frische HLC-Werte in einem Poll wurde dadurch der zuletzt bekannte SoC-Wert mitNoneüberschrieben statt erhalten zu bleiben - das war die Ursache des abwechselnden Wert/None-Musters im Log.#4029