Conversation
okurz
force-pushed
the
feature/container
branch
3 times, most recently
from
September 29, 2026 14:31
1ceae88 to
265dcaf
Compare
|
okurz
force-pushed
the
feature/container
branch
from
September 29, 2026 14:37
5ee238b to
265dcaf
Compare
okurz
marked this pull request as ready for review
September 29, 2026 14:38
Motivation: Installing system packages via apt-get and Python packages via pip on every Action run is slow and inefficient. We need a pre-packaged environment to optimize workflow execution time. Design Choices: 1. Create container/Containerfile with required system, pip, and font dependencies (dejavu-fonts, ghostscript-fonts-std) to enable pre-building the environment image. 2. Extract the composite action steps into entrypoint.sh. 3. Configure action.yaml to execute using the container/Dockerfile with entrypoint.sh as the script arguments. Benefits: Establishes the initial containerized execution pattern. Once the OBS image is pre-built and published, startup times will be reduced to near-zero by fetching the image directly instead of installing packages on-the-fly.
Motivation: Using a Bash orchestrator for a Python application introduces unnecessary complexity and language mixing. Furthermore, empty or corrupted state files can cause the tool to crash, and workspace ownership security checks can cause git commands to fail inside the container. Design Choices: 1. Implement entrypoint.py to handle runner context and HTML/PNG rendering entirely in Python. 2. Configure action.yaml to use the Python entrypoint directly. 3. Configure Git to trust /github/workspace globally to avoid ownership errors. 4. Clean up the empty state.json file if the state retrieval command fails. 5. Enhance get_state() in backlogger.py to be defensive against empty/malformed files. Benefits: Consolidates the runner orchestration to Python, eliminating the need for shell tools like sed, making it easier for Python developers to maintain, and ensuring robust, error-tolerant state management and execution.
okurz
force-pushed
the
feature/container
branch
from
September 29, 2026 15:17
265dcaf to
2412fb4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.