Repository navigation
Conversation
Signed-off-by: Vignesh <vickyofficial26@gmail.com>
|
|
panthera-momagdii
left a comment
There was a problem hiding this comment.
Direction is good, but H-CI-1 is not complete yet against the work-package acceptance you shared.
Please close these before approval:
- The new image workflow only runs on
pushtomain/ manual dispatch, so this PR has no hosted Docker build validation. Add a PR build-only path (no GHCR push) so a broken Dockerfile cannot merge green. - After the publish path is proven, record/pin the produced image digest in the manifest.
- Use that same pinned image for contributor development through a devcontainer, and show a contributor can open it and reach a working build.
- Add evidence for the cold pull-request software gate staying within the 10-minute budget.
- The image currently installs
ros-jazzy-rplidar-ros, while the current 2.0 S3 path is moving tosllidar_ros2from the pinned source manifest. Please either document why the legacy package is still intentionally needed in the baseline image or align the image with the current driver path.
Repository-quality and CLA are green, but they do not validate the container build/publish path itself. Re-request review once the hosted image build and H-CI-1 acceptance evidence are present.
panthera-momagdii
left a comment
There was a problem hiding this comment.
Direction is good, but H-CI-1 is not complete yet against the stated acceptance criteria.
Please close these before approval:
- The image workflow only runs on push to
main/ manual dispatch, so this PR has no hosted Docker build validation. Add a pull-request build-only path (no GHCR push) so a broken Dockerfile cannot merge green. - After the publish path is proven, record and pin the produced image digest in the manifest.
- Use the same pinned image for contributor development through a devcontainer and show that a contributor can open it and reach a working build.
- Add evidence that a cold pull-request software gate stays within the 10-minute budget.
- The image currently installs
ros-jazzy-rplidar-ros, while the current 2.0 S3 path is moving tosllidar_ros2from the pinned source manifest. Either document why the legacy package is intentionally kept in the baseline image or align the image with the current driver path.
Repository-quality and CLA are green, but they do not validate the container build/publish path itself. Re-request review once the hosted image build and H-CI-1 acceptance evidence are present.
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
a548857 to
d929043
Compare
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
Summary
Adds the initial H-CI-1 baseline CI container image for ROS 2 Jazzy and a GitHub Actions workflow for publishing the image to GHCR.
Changes
Validation
Tested locally against
openamr-platform-sw.colcon build --symlink-install: ~1m17sKnown issue
micro_ros_agentdoes not currently have a rosdep definition for Ubuntu Noble. The platform workspace still builds successfully.