Clearing additional objects map

[fjtirado]

Besides calling Closeable for every additional object, the holding map should be clear in case the WorkflowInstance is not removed from memory (which currrently might happen only for scheduled instances)

[Copilot]

Pull request overview

This PR aims to prevent retained WorkflowMutableInstance objects (notably scheduled instances) from holding onto metadata indefinitely by clearing the instance’s additionalObjects map when execution completes.

Changes:

• Clear additionalObjects during workflow completion cleanup in WorkflowMutableInstance.whenCompleted(...).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowMutableInstance.java:131

• handleException is now only invoked from whenCompleted, which is attached to processTaskList(...). If an exception occurs later in the chain (e.g., in whenSuccess output filtering/schema validation, or during onWorkflowCompleted event publication), the overall future will complete exceptionally but the instance will not be marked FAULTED and WorkflowFailedEvent will not be published (regression vs. when cleanUp handled ex). Consider handling ex in cleanUp as well (guarded to avoid double-reporting).

    additionalObjects.clear();
    workflowContext.definition().removeInstance(this);