Skip to content

Bump the all-dependencies group with 14 updates#281

Open
kumaradityaraj wants to merge 4 commits into
open-workflow-specification:mainfrom
kumaradityaraj:depBot277
Open

Bump the all-dependencies group with 14 updates#281
kumaradityaraj wants to merge 4 commits into
open-workflow-specification:mainfrom
kumaradityaraj:depBot277

Conversation

@kumaradityaraj

Copy link
Copy Markdown
Contributor

Closes #277

Bumps the all-dependencies group with 14 updates:

Package From To
@openworkflowspec/sdk 1.0.3-alpha4 1.0.3-alpha5
@storybook/addon-a11y 10.5.2 10.5.3
@storybook/addon-docs 10.5.2 10.5.3
@storybook/addon-vitest 10.5.2 10.5.3
@storybook/react-vite 10.5.2 10.5.3
@testing-library/jest-dom 6.9.1 7.0.0
lint-staged 17.0.8 17.1.1
lucide-react 1.25.0 1.26.0
oxfmt 0.59.0 0.60.0
oxlint 1.74.0 1.75.0
radix-ui 1.6.2 1.6.5
react-dom 19.2.7 19.2.8
react 19.2.7 19.2.8
storybook 10.5.2 10.5.3

Invalid tests have been removed and some tests have been mofidied

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Copilot AI review requested due to automatic review settings July 27, 2026 09:57
@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for openworkflow-editor ready!

Name Link
🔨 Latest commit 8f3f5cb
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6a6730767076070008f5ecce
😎 Deploy Preview https://deploy-preview-281--openworkflow-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the dependency set (notably @openworkflowspec/sdk) and aligns test expectations with updated workflow graph/node identity behavior by refreshing snapshots and Playwright E2E selectors.

Changes:

  • Updated buildFlatGraph integration snapshot to reflect new node IDs and added taskReference fields.
  • Updated Playwright E2E tests to use the new node/test-id formats (removing numeric index segments like /do/0/...).
  • Reduced assertions in one E2E test that previously verified node-level validation error UI.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

File Description
packages/open-workflow-diagram-editor/tests/core/snapshots/workflowSdk.integration.test.ts.snap Snapshot updated for new graph node IDs and taskReference fields.
packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts E2E selector updated; error-related assertions removed.
packages/open-workflow-diagram-editor/tests-e2e/for-loop.spec.ts E2E selectors updated for new node/test-id formats.
packages/open-workflow-diagram-editor/tests-e2e/diagram-editor.spec.ts Updated React Flow node test-id to match new node IDs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts Outdated
Copilot AI review requested due to automatic review settings July 27, 2026 10:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts:28

  • This test is named as validating an error state, but it no longer asserts that the node actually renders a validation error indicator (error badge / has-error class). Given the SDK change that decouples node IDs from document paths, this risks masking a regression where validation errors no longer attach to nodes.
  await expect(page.getByTestId("listen-node-/do/listenToGossips-badge")).toHaveText("any");
});

Copilot AI review requested due to automatic review settings July 27, 2026 10:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts:27

  • This change removes the only end-to-end assertions that validation errors are rendered on nodes (error badge visibility and has-error class). After this PR, tests-e2e no longer appears to cover node-level error highlighting, which makes it easier for SDK-breaking changes to regress UI error feedback without detection.

Consider adding/keeping an E2E scenario that intentionally triggers a node-owned validation error and asserts the node shows the error badge and has-error class (updating testIds to the new node identity scheme).

test("renders listen node with any badge", async ({ page }) => {
  await page.goto("/iframe.html?id=examples-workflows--listen-to-any-forever-foreach");

  const node = page.getByTestId("listen-node-/do/listenToGossips");

  await expect(node).toContainText("listenToGossips");
  await expect(node).toContainText("LISTEN");

  await expect(page.getByTestId("listen-node-/do/listenToGossips-badge")).toHaveText("any");

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Copilot AI review requested due to automatic review settings July 27, 2026 10:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/open-workflow-diagram-editor/tests-e2e/forever-foreach.spec.ts:23

  • This test used to assert node-level validation UI (error badge + has-error class) but now only checks the badge text. Given the @openworkflowspec/sdk update decouples node IDs from document paths (graph snapshot IDs like "/do/step1" vs validation error paths like "/do/0/checkup" in workflowSdk.integration snapshots), removing these assertions may hide a regression where node errors no longer attach to the correct node. Please add/restore an end-to-end check for node-level errors (e.g. Storybook features-validation-errors--node-error) and ensure error-to-node mapping uses the graph node’s taskReference (document path) rather than id.
test("renders listen node with any badge", async ({ page }) => {
  await page.goto("/iframe.html?id=examples-workflows--listen-to-any-forever-foreach");

  const node = page.getByTestId("listen-node-/do/listenToGossips");

Comment thread packages/open-workflow-diagram-editor/tests-e2e/for-loop.spec.ts

@lornakelly lornakelly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @kumaradityaraj but please look at the DCO check

@lornakelly

Copy link
Copy Markdown
Collaborator

@kumaradityaraj Please also close the original dependabot PR with comment that you are closing in favour of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants