Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| jobs: | ||
| lint-openrpc: | ||
| name: Lint OpenRPC | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out the repository | ||
| uses: actions/checkout@v7 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v7 | ||
| with: | ||
| node-version: "24" | ||
| cache: npm | ||
|
|
||
| - name: Install dependencies |
There was a problem hiding this comment.
I'd change this to be generic, and use npm install , and then I'd maybe just call npx open-rpc-linter with a name of file or completely inline the example so someone knows full story of setting it up.
| - New executable rule functions must be compiled into the linter; YAML rules | ||
| can only use registered functions. | ||
|
|
||
| The linter is currently pre-1.0. Pin a release in CI when reproducible behavior |
There was a problem hiding this comment.
probably could drop this comment might not age
zcstarr
left a comment
zcstarr
left a comment
There was a problem hiding this comment.
This generally looks good to me a few minor nits, the most lingering one is probably that the github actions ci should not use assumed npm as context, if we switch to using npx as the command entry point , and drop npm install then users using say C++ , rust, or go will also gain the benefit of the yml file and won't require an additional kind of setup assumption.
| --rules rules/defaults/recommended.yaml | ||
| ``` | ||
|
|
||
| With release `v0.0.17`, the command exits non-zero and reports: |
There was a problem hiding this comment.
| With release `v0.0.17`, the command exits non-zero and reports: | |
| The command exits non-zero and reports: |
There was a problem hiding this comment.
Probably ok to drop the version reference here
| - New executable rule functions must be compiled into the linter; YAML rules | ||
| can only use registered functions. | ||
|
|
||
| The linter is currently pre-1.0. Pin a release in CI when reproducible behavior |
2 participants
Summary
Verification
bun run buildpasses and prerenders both new linter routes