Repository navigation
refactor(qruov): deduplicate signature wrappers across implementations - #2643
Open
0rlych1kk4 wants to merge 1 commit into
Open
0rlych1kk4 wants to merge 1 commit into
0rlych1kk4 wants to merge 1 commit into
Conversation
0rlych1kk4
requested review from
baentsch,
dstebila and
xuganyu96
as code owners
October 23, 2026 06:39
Signed-off-by: 0rlych1kk4 <orlychikka@gmail.com>
0rlych1kk4
force-pushed
the
refactor/qruov-signature-wrapper-dedup
branch
from
October 23, 2026 06:43
fde2886 to
bdae4a9
Compare
Contributor
Author
|
The CI is green on the signed-off commit Local validation also completed:
The shared wrapper is byte-identical to the original copies, with implementation-specific compilation preserved. Ready for review. Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2638.
Consolidates the 90 identical QR-UOV
signature.cwrappers into a single shared source file while preserving per-implementation compilation and symbol namespacing.The refactor uses the existing
include_only: truecommon-dependency mechanism in the upstream importer. Each of the 90 implementation targets continues to compile the shared source with its own configuration and compile flags.No changes were made to the signature wrapper's contents or the cryptographic algorithm.
Changes
signature.cfiles to one shared source atsrc/sig/qruov/qruov_qruov_common/signature.c.f296750f4793b8350bd2352ded890e9a811be42a.The shared wrapper's SHA-256 remains identical to the original copies.
Validation
Platform: macOS ARM64, AppleClang 21.0.0
tests/KATs/sig/kats.json.No new test was added because this is a source deduplication rather than a new feature. The existing signature tests and registered KAT tests cover the refactored functionality.
The x86-64 optimized and AVX2 implementations were not executed locally; those configurations require CI validation.
Upstream dependency
The corresponding QR-UOV integration metadata change is available at:
0rlych1kk4/round3@f296750
This change is independent of the QR-UOV AES backend consolidation in #2642.
Compatibility
Neither applies. The refactor preserves the existing algorithm implementations, algorithm names, public API and registered KAT values.
Generative AI disclosure
Generative AI assistance was used to draft and refine documentation. All technical changes and validation results were reviewed and verified by the contributor before submission.