Skip to content

Add SQIsign - #2593

Open
bhess wants to merge 12 commits into
mainfrom
bhe-sqisign
Open

bhess wants to merge 12 commits into
mainfrom
bhe-sqisign

Conversation

@bhess

@bhess bhess commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Adds NIST round 3 candidate SQIsign:

Integrated using copy_from_upstream.
The code is self-contained, using SHAKE from liboqs common code.

TODOs:

  • Currently points to a staging-repo with some modifications to support all liboqs builds. Move to the upstream repo once those changes are integrated.
  • Create -tracker branch in oqs-provider

Closes #1946

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged. Also, make sure to update the list of algorithms in the continuous benchmarking files: .github/workflows/kem-bench.yml and sig-bench.yml)

@bhess
bhess force-pushed the bhe-sqisign branch 2 times, most recently from 4f0b5a6 to 6e92f4d Compare September 25, 2026 15:20
Comment thread src/sig/sqisign/the-sqisign_sqisign_common/integers.c Fixed
Comment thread src/sig/sqisign/the-sqisign_sqisign_common/integers.c Fixed
@bhess
bhess force-pushed the bhe-sqisign branch 2 times, most recently from d1b7998 to f82c7b5 Compare September 25, 2026 16:04
@coveralls

coveralls commented Sep 25, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 70.281% (-15.0%) from 85.245% — bhe-sqisign into main

@RodriM11

Copy link
Copy Markdown
Member

thank you a lot for this @bhess !

@RodriM11

Copy link
Copy Markdown
Member

As discussed in yesterday's TSC meeting, @xuganyu96 and I will act as reviewers for this PR.

bhess added 10 commits October 27, 2026 15:38
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
bhess added 2 commits October 27, 2026 15:38
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
@bhess
bhess marked this pull request as ready for review October 27, 2026 16:35

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

[Feature request] SQIsign

5 participants