Drop the private workspace reservation from public mapsight - #294
Merged
Conversation
The Braunschweig plan app and generic private docs have left this checkout. Public mapsight no longer reserves private/ workspace paths.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
private/apps/*andprivate/packages/*from the public workspace, plus the leak-check script, CI job, and husky hook calls.Test plan
node --test configs/lint-staged.test.mtscheck(starter-pins only) and remaining jobspnpm-workspace.yamlonmainhas noprivate/globs after mergeNote
Medium Risk
Removes automated guards against accidental
private/content on publicmain; mistaken commits of sensitive paths would no longer be caught locally or in CI.Overview
Removes the monorepo’s reserved
private/workspace (private/apps/*,private/packages/*frompnpm-workspace.yaml) and all tooling that preventedprivate/paths from appearing on public branches.Deleted
scripts/check-no-private-leak.mtsand thecheck:no-private-leakscript; rootpnpm run checknow only runscheck:starter-pins. The dedicated CIno-private-leakjob is removed from.github/workflows/ci.ymland from theci-passgate. Husky pre-commit and pre-push no longer invoke the leak checker (pre-push still blocks pushingprivate/*branch names to non-privateremotes).lint-staged path resolution is simplified to public
packages/andapps/only, with matching test updates. Contributor docs drop the private-workspace and private-sync sections; linked-host guidance no longer referencesprivate/develop.Reviewed by Cursor Bugbot for commit 9371a87. Bugbot is set up for automated code reviews on this repo. Configure here.