Skip to content

Drop the private workspace reservation from public mapsight - #294

Merged
pjeweb merged 1 commit into
mainfrom
chore/retire-private-workspace
Sep 12, 2026
Merged

Drop the private workspace reservation from public mapsight#294
pjeweb merged 1 commit into
mainfrom
chore/retire-private-workspace

Conversation

@pjeweb

@pjeweb pjeweb commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove private/apps/* and private/packages/* from the public workspace, plus the leak-check script, CI job, and husky hook calls.

Test plan

  • node --test configs/lint-staged.test.mts
  • CI check (starter-pins only) and remaining jobs
  • Confirm pnpm-workspace.yaml on main has no private/ globs after merge

Note

Medium Risk
Removes automated guards against accidental private/ content on public main; mistaken commits of sensitive paths would no longer be caught locally or in CI.

Overview
Removes the monorepo’s reserved private/ workspace (private/apps/*, private/packages/* from pnpm-workspace.yaml) and all tooling that prevented private/ paths from appearing on public branches.

Deleted scripts/check-no-private-leak.mts and the check:no-private-leak script; root pnpm run check now only runs check:starter-pins. The dedicated CI no-private-leak job is removed from .github/workflows/ci.yml and from the ci-pass gate. Husky pre-commit and pre-push no longer invoke the leak checker (pre-push still blocks pushing private/* branch names to non-private remotes).

lint-staged path resolution is simplified to public packages/ and apps/ only, with matching test updates. Contributor docs drop the private-workspace and private-sync sections; linked-host guidance no longer references private/develop.

Reviewed by Cursor Bugbot for commit 9371a87. Bugbot is set up for automated code reviews on this repo. Configure here.

The Braunschweig plan app and generic private docs have left this
checkout. Public mapsight no longer reserves private/ workspace paths.
@changeset-bot

changeset-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9371a87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pjeweb
pjeweb merged commit 9dd1267 into main Sep 12, 2026
22 checks passed
@pjeweb
pjeweb deleted the chore/retire-private-workspace branch September 12, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant