Stop CSV-to-GeoJSON pipelines from crashing on PHP 8.2+ - #21
Merged
Conversation
Merge no longer requires a CRS, and CSV handlers drop blank trailing lines instead of passing null into stripslashes or coordinate columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulp-geojsonmerge no longer TypeErrors when input FeatureCollections have no CRS.pulp-geojsonfromCsv keeps UTF-8 as UTF-8, maps every row, and no longer passes null intostripslashes().pulp-geocsvdrops blank trailing lines and treats missing X/Y as no geometry instead of warning.Test plan
vendor/bin/phpunit --testsuite pulp-geojson,pulp-geocsvpulp-geojson@v1.0.4andpulp-geocsv@v1.0.3if we want Packagist releases.