Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new installer regression test needs platform gating to avoid failures on native Windows.
1 open finding
What changed in this PR
Addresses #66 by preventing npm-managed self-updates and rejecting older releases during standalone updates.
Changes:
- Mark npm launches as package-managed and direct updates to the package manager.
- Pass the running version to the installer and reject downgrades.
- Add regression coverage and clarify update scope in documentation.
| File | Description |
|---|---|
| SKILL.md | Clarifies standalone update scope. |
| npm/SKILL.md | Clarifies standalone update scope. |
| npm/scripts/test-package.js | Tests the launcher’s package-managed marker. |
| npm/bin/gsd-browser | Sets the package-managed marker. |
| install.sh | Adds version comparison and downgrade refusal. |
| gsd-browser-skill/workflows/setup-and-configure.md | Documents package-manager update instructions. |
| gsd-browser-skill/references/command-reference.md | Explains update scope. |
| cli/src/main.rs | Guards updates, passes the current version, and adds tests. |
| CHANGELOG.md | Records the updater safeguards. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #66.
gsd-browser updatefrom that launcher instead of installing a separate binary and claiming success. The error directs users to their package manager (orgsd update browserunder GSD Pi).Verification
Passed:
cargo fmt --checkbash -n install.shgit diff --checknpm --prefix npm testcargo test -p gsd-browser --bin gsd-browser cli_output_tests(4 passed)The full
cargo test -p gsd-browserrun did not finish within the 10-minute local limit; it was still running longinstruction_runtimetests when terminated. No full-suite pass is claimed.