Repository navigation
feat: add win32-arm64 platform support - #63
Merged
Merged
Conversation
Adds the aarch64-pc-windows-msvc target to the release and npm-publish build matrices on the windows-11-arm hosted runner, and the gsd-browser-windows-arm64.exe artifact to the release file lists, the three npm-publish required_assets guards, the postinstall PLATFORM_MAP, and the test-package asset assertions. README/npm/README platform tables and the changelog note the new target. Fixes npm install on Windows ARM64, which previously failed with 'unsupported platform win32-arm64' in postinstall. (open-gsd/gsd-pi#1604)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
What: Adds
win32-arm64as a supported platform — build matrix, release asset, npm-publish guards, postinstall platform map, test assertions, and docs.Why:
npm install -g @opengsd/gsd-browserfails on Windows ARM64 withunsupported platform win32-arm64(reported via open-gsd/gsd-pi#1604).How: Mirrors the existing per-platform pattern:
aarch64-pc-windows-msvcbuild on thewindows-11-armhosted runner,gsd-browser-windows-arm64.exerelease asset wired into all threerequired_assetsguards and both file lists, plus the postinstall/test/docs entries.What
.github/workflows/release.yml+npm-publish.yml— new matrix entry; the npm-publish asset-verification guards and release file lists include the new artifact.npm/scripts/postinstall.js+test-package.js— PLATFORM_MAP and asset assertions.README.md/npm/README.md/CHANGELOG.md— platform table rows and changelog entries.Why
Windows ARM64 users cannot install the package at all today: the postinstall platform gate rejects
win32-arm64.aarch64-pc-windows-msvcis a Tier 1 Rust target, thewindows-11-armhosted runner (free for public repos) ships ARM64 MSVC tools, and the browser stack attaches to the user's installed Chrome/Edge — both of which ship native ARM64 Windows builds. No gsd-pi code changes are needed: its gsd-browser gates are os-level and arch-agnostic.How
Purely declarative — every hunk mirrors its neighboring platform entry. Independent verification: PLATFORM_MAP keys ==
package.jsonos×cpu == workflow matrices == file lists == required_assets (both directions); YAML valid;test-package.jspasses; no other platform-enumeration sites exist (install.sh and the launcher shim are arch-agnostic by design).Note: the ARM64 build itself proves out on the first tagged release (no local Windows ARM64 toolchain here). Re-running npm-publish against a historical tag whose release lacks the new asset will fail the asset gate loudly — consistent with existing policy.