Skip to content

test(lib): ensure TerraformAsset stage within stack own directory - #434

Merged
jsteinich merged 1 commit into
open-constructs:mainfrom
eduardomourar:test/asset-staging-directory-regression
Sep 15, 2026
Merged

jsteinich merged 1 commit into
open-constructs:mainfrom
eduardomourar:test/asset-staging-directory-regression

Conversation

@eduardomourar

@eduardomourar eduardomourar commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Related issue

Follow-up from #380.

Description

#380 claimed asset staging lands as a sibling of stacks/, breaking once uploaded to a hosted runner. Traced it: TerraformAsset already stages inside stacks/<stack-id>/, and has since before #371. The bug only ever existed in the old, never-merged spike's AssetStaging, which #433 didn't carry forward.

No code fix needed. Adds a regression test pinning this contract so it can't regress silently later (e.g. in #339).

Checklist

  • I have updated the PR title to match CDKTN's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@eduardomourar
eduardomourar requested a review from a team as a code owner September 14, 2026 00:18

@jsteinich jsteinich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheap and worth having. One framing note below, plus: this touches canonical-asset-hash.test.ts, as does #433, so the two will likely conflict — worth picking a merge order.

Comment thread packages/cdktn/test/canonical-asset-hash.test.ts
@eduardomourar eduardomourar changed the title test(lib): ensure asset staging within stack own directory test(lib): ensure TerraformAsset stage within stack own directory Sep 14, 2026
@eduardomourar

Copy link
Copy Markdown
Contributor Author

I would like to merge this PR first as it is smaller.

@jsteinich
jsteinich merged commit 9a80366 into open-constructs:main Sep 15, 2026
262 checks passed
@eduardomourar
eduardomourar deleted the test/asset-staging-directory-regression branch September 15, 2026 20:12
@so0k so0k added the assets label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants