feat(aws-certificatemanager): add DnsValidatedCertificateV2 - #82
Open
garysassano wants to merge 11 commits into
Open
garysassano wants to merge 11 commits into
garysassano wants to merge 11 commits into
Conversation
garysassano
marked this pull request as ready for review
September 6, 2026 09:20
DnsValidatedCertificateV2
garysassano
force-pushed
the
feat/native-dns-certificate
branch
from
September 6, 2026 09:28
4b9484e to
3435896
Compare
garysassano
marked this pull request as draft
September 6, 2026 09:56
garysassano
marked this pull request as ready for review
September 6, 2026 12:23
2 tasks
garysassano
force-pushed
the
feat/native-dns-certificate
branch
from
September 23, 2026 02:34
4e5adfb to
eff05ed
Compare
garysassano
marked this pull request as draft
September 23, 2026 02:35
garysassano
force-pushed
the
feat/native-dns-certificate
branch
from
September 23, 2026 02:43
eff05ed to
32556ec
Compare
garysassano
marked this pull request as ready for review
September 23, 2026 02:53
garysassano
force-pushed
the
feat/native-dns-certificate
branch
from
September 23, 2026 09:59
32556ec to
291fe7e
Compare
Follow the module README layout used by the other constructs, move the integration runbook into the fixture, and restore the root README and .npmignore to main.
Deployed against a real public zone, then regenerated with the placeholder zone Z23ABC4XYZL05B / example.com used by aws-cdk.
Generated owners were named dns-validated-certificate-stack-<hash>-<region>, which is opaque in the CloudFormation console and becomes permanent once deployed. Name them <containing stack>-certificates-<region> instead, and reject a name shared by two different containing stacks. Also stop doubling the construct path in the certificate factory error.
garysassano
force-pushed
the
feat/native-dns-certificate
branch
5 times, most recently
from
September 23, 2026 12:38
9681d34 to
24425ec
Compare
garysassano
force-pushed
the
feat/native-dns-certificate
branch
from
September 23, 2026 12:45
24425ec to
d58e7a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
DnsValidatedCertificateV2creates a public DNS-validated ACM certificate with native CloudFormation resources. For cross-region use,certificateRegioncreates the owner stack, re-imports the Route 53 zone, and checks the primary name and SANs against zone authority. Core CDK already supports sharing a certificate from an explicitly managed owner stack.Description of changes
certificateRegion, or use an explicitcertificateStack. Generated owners are named<containing stack>-certificates-<region>.hostedZonesByDomainmapping, and expose the standardICertificateinterface.Description of how you validated changes
npm run buildpassed 436 tests, including 196 ACM tests.us-east-1, CloudFront deployed fromeu-central-1with the expected viewer certificate, and both assertions passed. All stacks, the certificate, the distribution, and the validation record were removed afterwards.Z23ABC4XYZL05B/example.comthat aws-cdk uses, so it contains no real account or hosted-zone identifiers. It comparesUNCHANGEDwith those values.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license