Skip to content

fix(connections): hide reconnect actions for read-only members - #406

Merged
alwaysmavs merged 1 commit into
mainfrom
codex/fix-read-only-connection-reconnect
Oct 27, 2026
Merged

alwaysmavs merged 1 commit into
mainfrom
codex/fix-read-only-connection-reconnect

Conversation

@alwaysmavs

Copy link
Copy Markdown
Contributor

Non-admin members viewing an OAuth or API-key connection saw a permanently spinning authorization button because the read-only path set reconnectBlocked unconditionally.

Hide reconnect actions for members without connection management permission, matching Console behavior, while preserving the working View access action. Remove the read-only path's unconditional authorization-blocked flag.

Validation:

  • Regression tests reproduce the incorrect button before the fix for OAuth and API-key accounts, and pass after the fix.
  • Administrator reconnect, authorization waiting, and return to idle are covered.
  • 40 tests pass across ConnectionAccountsList, connection-route-model, and connection-oauth-pending.
  • TypeScript, changed-file lint and formatting, and git diff --check pass.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 334c802f-db40-414c-89cd-dcde8cb47c84
Commits

Reviewing files that changed from the base of the PR and between d568845 and 1758d48.

Files selected for processing: 3
  • src/routes/Connections/ConnectionAccountsList.test.tsx
  • src/routes/Connections/ConnectionAccountsList.tsx
  • src/routes/Connections/ConnectionProviderDetailPane.tsx
Files with no reviewable changes: 1
  • src/routes/Connections/ConnectionProviderDetailPane.tsx

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Summary by CodeRabbit

  • Bug Fixes
    • Reconnect actions are now limited to accounts users can manage. Read-only accounts retain the “View access” action without showing reconnect loading indicators or triggering a reconnect.
    • For manageable accounts, reconnect remains available when appropriate, and the button and loading indicator now reflect polling status correctly.

Walkthrough

The reconnect action now appears only when the user can manage connections and the app has a valid reconnect authentication type. The read-only detail pane no longer passes the reconnectBlocked prop. Tests cover read-only OAuth2 and API-key accounts, and reconnect button behavior while polling starts and stops.

Priority: Normal

Merge Risk: Minimal · up to 1758d

No actionable merge-blocking issue is established; the change is mergeable after normal checks.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the bug, intended behavior, regression coverage, and reported validation. It does not follow the required template because it omits the ## Summary, ## Verification, and `#… Update the description to use the repository template. Add the required headings, mark the applicable verification checks, and address each Safety and Compatibility item, including credential exposure, permissions, migrations, packaging, up…
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title follows the required <type>(<scope>): <subject> format, uses English, and accurately describes the change.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the bug, intended behavior, regression coverage, and reported validation. It does not follow the required template because it omits the ## Summary, ## Verification, and ## Safety and Compatibility headings, the verification checklist, and all safety and compatibility items.

Resolution

Update the description to use the repository template. Add the required headings, mark the applicable verification checks, and address each Safety and Compatibility item, including credential exposure, permissions, migrations, packaging, updates, documentation, and tests.

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@alwaysmavs
alwaysmavs merged commit fbcf8f6 into main Oct 27, 2026
2 checks passed
@alwaysmavs
alwaysmavs deleted the codex/fix-read-only-connection-reconnect branch October 27, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant