Skip to content

feat(ui): streamline team and settings navigation - #400

Merged
alwaysmavs merged 1 commit into
mainfrom
codex/team-settings-navigation
Sep 29, 2026
Merged

alwaysmavs merged 1 commit into
mainfrom
codex/team-settings-navigation

Conversation

@alwaysmavs

Copy link
Copy Markdown
Contributor

Summary

Team management previously had duplicate navigation entries and retained the application sidebar, unlike Settings. Both pages also devoted a large content row to their titles, reducing the vertical space available for configuration and skill lists. Page changes were abrupt.

This change removes the Team sidebar entry and labels the existing workspace-menu entry as Team settings. Team management now uses the standalone page shell with a Back to app action, while retaining its skills, members, settings, and team-switching functionality. The shared shell supports a height-constrained layout so the team list scrolls internally without a second page scrollbar.

Team and Settings titles now appear inline in the titlebar, and their content starts with 20px of top padding. Content enters with a 200ms fade and 6px upward movement; returning to the application uses a 180ms fade. Reduced-motion preferences disable these animations. The team page retains its lazy-loading boundary so its entry animation starts when the route is ready.

Validation

  • Full repository lint: corepack pnpm run lint — passed.
  • TypeScript: corepack pnpm run ts-check — passed.
  • Related tests: PageRouteShell, SidebarAccountControls, and i18n catalog — 26 tests passed.
  • git diff --check — passed.
  • Verified in the running Wanta Local Electron app: sidebar entry removal, workspace-menu navigation, standalone team page, skill-list scrolling, all three team tabs, compact titlebar titles on both pages, and return navigation.

Open team management as a standalone page from the workspace menu. Move page titles into the titlebar and reduce top spacing. Add gentle entry transitions with reduced-motion support.
@alwaysmavs
alwaysmavs marked this pull request as ready for review September 29, 2026 14:47
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 086ad2f5-f295-4c7f-b9bc-31a6263cfd20

📥 Commits

Reviewing files that changed from the base of the PR and between f580550 and e499f19.

📒 Files selected for processing (6)
  • src/components/PageRouteShell.tsx
  • src/components/app-shell/AppShell.tsx
  • src/components/app-shell/AppShellNavigationSidebar.tsx
  • src/components/app-shell/SidebarAccountControls.tsx
  • src/routes/Settings/index.tsx
  • src/styles/theme.css

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Summary by CodeRabbit

  • New Features
    • Added page-entry animations for the app and page content; animations respect reduced-motion preferences.
    • Teams and Settings pages can display their titles in the page header. The Teams page also includes a back action and update action.
  • Changes
    • Updated the workspace menu label to “Team settings.”
    • Removed the Teams button from the sidebar navigation.
    • Added a full-height content layout option for pages.

Walkthrough

PageRouteShell now supports optional titles, scroll or fill layouts, and optional content animation. Settings uses the shell’s title and animation options. When OOMOL is enabled on the Teams route, AppShell renders TeamManagementRoute inside PageRouteShell. The Teams sidebar button is removed, and the workspace menu label changes to the team settings translation. App and page entry animations are added and disabled when reduced motion is preferred.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to e499f

No actionable navigation or layout regression was identified; proceed with routine checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses the required format feat(ui): <subject>, uses English, and accurately describes the navigation changes.
Description check ✅ Passed The description provides a clear summary and detailed validation results, including automated checks and runtime/UI verification. It omits the template's separate Safety and Compatibility section, but…
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@alwaysmavs
alwaysmavs merged commit 721e548 into main Sep 29, 2026
3 checks passed
@alwaysmavs
alwaysmavs deleted the codex/team-settings-navigation branch September 29, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant