Skip to content

fix(skills): fall back to cross-team action discovery - #381

Merged
l1shen merged 1 commit into
mainfrom
fix/oo-cross-team-search-fallback
Oct 27, 2026
Merged

l1shen merged 1 commit into
mainfrom
fix/oo-cross-team-search-fallback

Conversation

@l1shen

@l1shen l1shen commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

When the current team has no usable action, the oo skill currently stops even if another team has a connected account. Allow one automatic search with the same query and --all-teams after a successful current-team search returns no matching available action.

Keep the fallback rules in the search reference and apply them before reporting discovery blockers. Explicit team restrictions, search command failures, and connector execution failures do not trigger fallback. Cross-team results retain their team and connection identity without changing the saved team or automatically authorizing execution.

Validation:

  • bun run lint:fix
  • bun run ts-check
  • bun run knip
  • git diff --check
  • Codex and Claude skill template rendering and frontmatter parsing

Documentation-only skill change. The generic skill validator does not support the existing template syntax/frontmatter field; project rendering and YAML parsing were used instead. No live agent behavior test was performed.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: ab074824-e1fa-4d8e-92b8-cb75426c9e68
Commits

Reviewing files that changed from the base of the PR and between 1082507 and a26f773.

Files selected for processing: 2
  • contrib/skills/shared/oo/SKILL.md
  • contrib/skills/shared/oo/references/search-and-selection.md

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Summary by CodeRabbit

  • New Features
    • In Hosted mode, searches with no available matching action now retry once across all teams, unless a team was explicitly specified or the search failed.
    • When a match is found in another team, its team and connection are identified. Confirmation is required before running it there, and the saved team remains unchanged.
  • Bug Fixes
    • Discovery results are checked for the eligible cross-team fallback before reporting missing actions or unavailable connections as blockers. Connector authorization blockers remain terminal after discovery.

Walkthrough

In Hosted mode, the search guidance now calls for one all-teams retry after a successful current-team search finds no matching available action, subject to stated exclusions. If the retry finds a match, the guidance requires identifying its team and connection and confirming intent before cross-team execution, without changing the saved team. The skill instructions require this fallback before treating discovery as blocked and keep connector authorization blockers terminal after discovery.

Possibly related PRs

  • oomol-lab/oo-cli#380: Adds --all-teams search and preserves team and app identifiers for cross-team results used by this guidance.

Priority: Normal

Merge Risk: Minimal · up to a26f7

The updated discovery guidance preserves authorization boundaries and introduces no established merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title "fix(skills): fall back to cross-team action discovery" follows the required (): format, is in English, and matches the main change: the oo skill now retries action di…
Description check Passed The description states the problem (the skill stops when the current team has no usable action even though another team has a connected account) and the fix (one automatic search with the same query a…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(skills): fall back to cross-team action discovery" follows the required <type>(<scope>): <subject> format, is in English, and matches the main change: the oo skill now retries action discovery across all teams after a successful current-team search finds no usable action.

Full details: Description check

Explanation

The description states the problem (the skill stops when the current team has no usable action even though another team has a connected account) and the fix (one automatic search with the same query and --all-teams). It also covers the fallback exclusions, identity handling, and validation steps, all of which match the changed search reference and SKILL.md blocker rule.

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@l1shen
l1shen merged commit d9e289a into main Oct 27, 2026
6 checks passed
@l1shen
l1shen deleted the fix/oo-cross-team-search-fallback branch October 27, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant