Repository navigation
[NodeGroupFusion] Roll back state after failed fusion validation - #1041
Open
minfhong-qti wants to merge 1 commit into
Open
minfhong-qti wants to merge 1 commit into
minfhong-qti wants to merge 1 commit into
Conversation
minfhong-qti
requested review from
qti-ashwshan,
qti-chuteng,
qti-shubham,
qti-yuduo,
tirupath-qti and
yuhuchua-qti
as code owners
October 27, 2026 07:04
Guard each fusion attempt and roll back newly registered tensors and parameters when validation or op affinity rejects it. Preserve existing wrappers and retain registrations for accepted fusions. Construct the BF16 restoration guard before conversion to clean up partial failures. Leave a TODO for preserving tensors that were originally BF16. Add component tests for rollback, acceptance, exception cleanup, nested guard rejection, normal builder fallback, and partial BF16 conversion failure. List the node-group suite in the component test README.
minfhong-qti
force-pushed
the
dev/minfhong/fusion-fail-rollback
branch
from
October 28, 2026 01:38
4c07a2b to
eae551c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guard each fusion attempt and roll back newly registered tensors and parameters when validation or op affinity rejects it. Preserve existing wrappers and retain registrations for accepted fusions.
Construct the BF16 restoration guard before conversion to clean up partial failures. Leave a TODO for preserving tensors that were originally BF16.
Add component tests for rollback, acceptance, exception cleanup, nested guard rejection, normal builder fallback, and partial BF16 conversion failure. List the node-group suite in the component test README.
Motivation and Context
Current node group fusion will leave stale wrappers in
QnnModelWrapperif validation fails. This issue further causes later op builder construction path potentially using incorrect wrappers.