Repository navigation
[QNN-EP] Early fail if nodes unsupported while disable CPU fallback. - #1028
Merged
Merged
Conversation
minfhong-qti
requested review from
qti-ashwshan,
qti-chuteng,
qti-kromero,
qti-shubham,
qti-yuduo,
quic-calvnguy,
tirupath-qti and
yuhuchua-qti
as code owners
October 21, 2026 03:42
kuanyul-qti
reviewed
Oct 21, 2026
minfhong-qti
force-pushed
the
dev/minfhong/fail-on-unsupported
branch
from
October 21, 2026 09:14
1f2ac5d to
2db334b
Compare
minfhong-qti
force-pushed
the
dev/minfhong/fail-on-unsupported
branch
from
October 22, 2026 02:04
2db334b to
4d44bb6
Compare
kuanyul-qti
reviewed
Oct 22, 2026
huaychou
reviewed
Oct 22, 2026
huaychou
left a comment
huaychou
left a comment
Collaborator
There was a problem hiding this comment.
Just wondering, does ORT core have similar mechanism to early stop?
minfhong-qti
force-pushed
the
dev/minfhong/fail-on-unsupported
branch
2 times, most recently
from
October 23, 2026 07:12
d3545a0 to
a7d57c4
Compare
Collaborator
Author
ORT provides an API to allow "user" to early stop. Refer to https://github.com/microsoft/onnxruntime/blob/main/include/onnxruntime/core/session/onnxruntime_c_api.h#L5571. Since EP can set this flag but it requires modifying user-own session option, it would have side effects. |
huaychou
approved these changes
Oct 27, 2026
huaychou
left a comment
huaychou
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Please check the CI failure.
kuanyul-qti
approved these changes
Oct 27, 2026
When disable_cpu_ep_fallback is set and there are unsupported nodes,
session initialization will eventually fail but only after performing
compile and graph transformations which can be skipped.
Introduce a new flag `has_unsupported_nodes_wo_cpu_fallback_` to early
return fail during Compile if such scenario occurs in GetCapability.
Test
- Add E2E testcases to check error code and message.
- partial unsupported nodes
- all unsupported nodes
- GetCapability pass 1 unsupport but pass 2 support
- Add framework op trace testcases.
minfhong-qti
force-pushed
the
dev/minfhong/fail-on-unsupported
branch
from
October 27, 2026 07:39
a7d57c4 to
fd01841
Compare
qti-chuteng
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new flag
has_unsupported_nodes_wo_cpu_fallback_to early return fail during Compile if such scenario occurs in GetCapability.Test
Motivation and Context
When disable_cpu_ep_fallback is set and there are unsupported nodes, session initialization will eventually fail but only after performing compile and graph transformations which can be skipped.