Expand doctor's dependency checks to cover all shelled-out tools - #4
Open
rlnorthcutt wants to merge 1 commit into
Open
rlnorthcutt wants to merge 1 commit into
rlnorthcutt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doctor previously checked only 6 of the ~12 external tools the lab shells out to, so a clean run gave false confidence right before a Windows- or screenshot-dependent lane failed on a missing tool.
Add genisoimage, cloud-localds, and socat as ERROR-level checks (core to running any guest lane), and ffmpeg, remote-viewer, and the lab-local swtpm binary as WARN-level checks (each affects only one optional feature or the Windows lane).