fix(agents): bound grep execution and spill oversized tool output - #376
Open
lefoulkrod wants to merge 5 commits into
Open
lefoulkrod wants to merge 5 commits into
lefoulkrod wants to merge 5 commits into
Conversation
lefoulkrod
marked this pull request as ready for review
September 9, 2026 00:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large tool results could overwhelm model context, and expensive Python regex searches could block the app. Oversized results now pass through
ToolResultCapHook, which saves their full text to a temporary file and publishes a bounded preview and path before persistence.The existing
greptool keeps its name, parameters, defaults, and Python matching semantics. Its async wrapper runs the matcher in a disposable process, kills and reaps it on timeout or cancellation, and retains partial matches. Search limits are explicit: 10 seconds, 1 MiB collected output, 8 MiB per file, 4,096-character line excerpts, and at most 10,000 matches. Incomplete results include retry guidance; context accepts 0–100 lines. There are no new search tools, dependency-management changes, or migration.Validation:
just checkandjust tool-docspassed.Fixes #272.