fix(providers): probe before persist on Test & add - #341
Open
VedantMadane wants to merge 2 commits into
Open
VedantMadane wants to merge 2 commits into
VedantMadane wants to merge 2 commits into
Conversation
VedantMadane
force-pushed
the
fix/provider-add-probe-before-persist-339
branch
from
September 7, 2026 07:01
75a3be5 to
ccdbfd7
Compare
Failed provider adds no longer leave orphan config. OpenAI-compatible brokered providers expose an editable base URL on the detail pane. Fixes omnideck-dev#339 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
VedantMadane
force-pushed
the
fix/provider-add-probe-before-persist-339
branch
from
September 9, 2026 15:05
ccdbfd7 to
3a36233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Failed "Test & add" no longer persists a provider before the upstream probe succeeds. Users can correct the URL/key and retry in place without deleting an orphan entry.
For brokered OpenAI-compatible providers (API key + base URL):
GET /api/providersreturns the non-secret mirrored base URL{ api_key, base_url }(backend already accepted this)Updates also probe before rewriting settings / rotating the vault entry so a bad save does not replace a working config.
Fixes #339
How it was tested
uv run pytest tests/unit/server/test_provider_routes.py -q(13 passed)save_settings/ supervisoraddnode scripts/release-notes.mjs validate-fragmentsRelease note
Added
release-notes.d/provider-add-probe-before-persist.md(target: app,type: fixed,area: providers).