Add release-artifact contract check; port hardware smoke script; add … - #6
Merged
Merged
Conversation
…TESTING.md
Compares this repo's test coverage against the sibling omnideck/desktop's
tests/, scripts/, and TESTING.md, porting what's proportionate to this
repo's current scope and closing the two known gaps already flagged in
RELEASING.md.
- tests/releasecontract/verify-release.mjs: static release-artifact
contract (exact 5-artifact matrix, per-format magic bytes, checksum
verification), scaled down from the sibling's 10-artifact/6-target
matrix. Wired into release.yml's publish job as a gate before
attestation/publish — catches a corrupted/truncated/wrong-architecture
artifact, which fail_on_unmatched_files alone doesn't. Verified against
the real published v0.5.0-alpha.2 release.
- tests/hardware/run.sh: automates the packaged-smoke launch/validate/
cleanup cycle. Found and fixed two real bugs while testing it for real,
not just porting working code: pgrep -x silently never matched
omnideck-desktop (kernel truncates comm to 15 bytes; switched to
pgrep -f), and an AppImage launched via --appimage-extract-and-run
reparents away from the tracked PID during extraction, leaving cleanup
unable to kill it (added a pkill -f fallback). Both use the
[o]mnideck-desktop bracket guard against self-matching.
- tests/hardware/validate-proof.test.mjs: unit tests for the proof
validator.
- tests/manual/published-artifact.md: checksum/attestation trust-
verification walkthrough — confirmed `gh attestation verify` works
against the real release before documenting it.
- TESTING.md: ties the test layers together (source, release contract,
native smoke, manual), sized to this repo's actual maturity rather than
the sibling's full alpha/beta/RC/stable promotion ladder. Documents what
was deliberately not ported (self-hosted hardware runners, run.ps1,
destructive host-reset tooling, post-publication re-verification) and
why, rather than silently skipping it.
RELEASING.md, README.md, and the two tests/*/README.md files updated to
match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…TESTING.md
Compares this repo's test coverage against the sibling omnideck/desktop's
tests/, scripts/, and TESTING.md, porting what's proportionate to this
repo's current scope and closing the two known gaps already flagged in
RELEASING.md.
tests/releasecontract/verify-release.mjs: static release-artifact contract (exact 5-artifact matrix, per-format magic bytes, checksum verification), scaled down from the sibling's 10-artifact/6-target matrix. Wired into release.yml's publish job as a gate before attestation/publish — catches a corrupted/truncated/wrong-architecture artifact, which fail_on_unmatched_files alone doesn't. Verified against the real published v0.5.0-alpha.2 release.
tests/hardware/run.sh: automates the packaged-smoke launch/validate/ cleanup cycle. Found and fixed two real bugs while testing it for real, not just porting working code: pgrep -x silently never matched omnideck-desktop (kernel truncates comm to 15 bytes; switched to pgrep -f), and an AppImage launched via --appimage-extract-and-run reparents away from the tracked PID during extraction, leaving cleanup unable to kill it (added a pkill -f fallback). Both use the [o]mnideck-desktop bracket guard against self-matching.
tests/hardware/validate-proof.test.mjs: unit tests for the proof validator.
tests/manual/published-artifact.md: checksum/attestation trust- verification walkthrough — confirmed
gh attestation verifyworks against the real release before documenting it.TESTING.md: ties the test layers together (source, release contract, native smoke, manual), sized to this repo's actual maturity rather than the sibling's full alpha/beta/RC/stable promotion ladder. Documents what was deliberately not ported (self-hosted hardware runners, run.ps1, destructive host-reset tooling, post-publication re-verification) and why, rather than silently skipping it.
RELEASING.md, README.md, and the two tests/*/README.md files updated to
match.