Skip to content

remove selects an instance positionally while every other command uses --name #32

Description

@lefoulkrod

--name is a persistent flag and is how start, stop, restart, status, logs and update choose an instance. remove takes a positional argument instead, and ignores --name:

$ omnideck remove --json --name desktop
Error: accepts 1 arg(s), received 0

For a scripted interface this is a trap, and it is worst on the one command that destroys things: a caller that builds its arguments uniformly gets an error on a good day, and on a bad day passes a name positionally somewhere that expected a flag.

Suggestion

Accept --name on remove like everything else, keeping the positional form working so nothing that exists today breaks. If only one may stay, the flag is the one that matches the rest of the surface.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions