Skip to content

The container this creates differs from the one the desktop application creates #31

Description

@lefoulkrod

Both the command line tool and the desktop application are meant to be valid ways to run Omnideck, and both should therefore produce the same container. They do not.

command line tool desktop application
web port -p <port>:8080 — every interface -p 127.0.0.1:<port>:8080
ENABLE_DESKTOP=false not set set
dev.omnideck.version label not set set
dev.omnideck.image-ref label not set set

Volumes, memory, shm size, restart policy, log driver and limits, and PORT=8080 all match.

The port difference is filed separately as #28 because it is a security default in its own right.

Why the other two matter

  • ENABLE_DESKTOP=false turns off the in-container desktop session. Without it an instance created here runs software the desktop application deliberately does not.
  • The two labels record which image a running container was created from. Anything reasoning about whether a container is current — repair, update, or a caller deciding whether to recreate — needs that, and inspecting the image reference alone does not answer it once a tag has moved.

Suggestion

Adopt both in RunOptions, so a container is the same container whichever tool made it. If either is genuinely desktop-only, saying so in a comment would be worth as much as the code.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions