Repository navigation
ci: run the unit tests and lint the diff on every pull request - #25
Merged
Merged
Conversation
Nothing ran on a pull request. `gh pr view` returned `statusCheckRollup: []` for every PR in the repo's history, so each one merged `CLEAN` purely because nothing was configured to say otherwise -- green and absent are indistinguishable to `gh`, and a merge gate reading "merge once fully green" was vacuous. The 470 unit tests ran only when someone remembered to run them. Two jobs. `test` syncs with `--frozen`, so a lockfile that has drifted from pyproject fails rather than quietly resolving something other than what developers run, then runs `pytest tests/unit`. `lint` runs ruff on the files the change touches, not the whole tree. The tree carries about 140 pre-existing ruff errors; gating on all of them would block every PR on work unrelated to it, and a check that cannot pass gets switched off. Gating the diff keeps new code clean while the backlog is paid down separately. Both the empty and non-empty paths of the diff step were exercised against real ranges before committing: no Python files changed yields a pass, and the previous two commits yield four files and a clean run. tests/integration is left out for now: it needs the docking stack, which is not on a hosted runner.
hallelx2
deleted the
halleluyaholudele/hal-4142-no-ci-runs-on-the-repo
branch
October 25, 2026 07:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing ran on a pull request.
gh pr viewreturnsstatusCheckRollup: []for every PR in this repo's history — #18 through #24 all mergedCLEANpurely because nothing was configured to say otherwise. Green and absent are indistinguishable togh, so a merge gate reading "merge once fully green" was vacuous. The 470 unit tests ran only when someone remembered to run them.Two jobs
test—uv sync --frozen --group devthenpytest tests/unit.--frozenis deliberate: a lockfile that has drifted frompyproject.tomlfails the job rather than quietly resolving something different from what developers run. Python is pinned to 3.13 (whatrequires-pythondemands) so a runner image change cannot move it silently.lint— ruff on the files the change touches, not the whole tree.The tree carries ~140 pre-existing ruff errors. Gating on all of them would block every PR on work unrelated to it, and a check that cannot pass is a check that gets switched off. Gating the diff keeps new code clean while the backlog is paid down separately.
Verified before committing
Both branches of the diff step were run against real ranges:
The empty case matters because
set -uplus an unset array is a common way for this exact step to break only on the PRs that touch no Python.The workflow YAML parses, and
uv sync --frozensucceeds against the current lock.Not done here
testa required status check onmain— that is a repository setting, not a file, and it cannot be set from the PR. It needs doing once in Settings → Branches after this merges, or the checks will run and still not block anything. Flagging rather than silently leaving it.tests/integration— left out; it needs the docking stack, which is not available on a hosted runner.Closes HAL-4142