Skip to content

Fix window owner detection when Spotlight adds .app - #39

Draft
schobiDotDev wants to merge 1 commit into
omarshahine:mainfrom
schobiDotDev:codex/mac-compat
Draft

schobiDotDev wants to merge 1 commit into
omarshahine:mainfrom
schobiDotDev:codex/mac-compat

Conversation

@schobiDotDev

Copy link
Copy Markdown

Summary

Strip a trailing .app from Spotlight display names before matching the Core Graphics window owner.

- "Find My.app" -> exact owner lookup fails
+ "Find My.app" -> "Find My" -> visible window found

Existing localized names and bundle-name fallbacks remain supported.

Evidence

  • Before: regression test failed for Find My.app, Localiser.app, and Wo ist?.app; devices --json --no-log failed with no visible Find My.app window on macOS 26 despite a visible window.
    After: regression passes and the same device command returns JSON on that Mac using the unchanged helper.
  • go test ./..., go vet ./..., make build, and git diff --check passed. Two independent source reviews found no issues.
  • Clawpatch was unavailable locally; no Clawpatch report was generated.

Merge Danger

Door: two-way

Revert the normalization and regression cases.

Blast Radius: window-detection

Only the final .app suffix is removed; empty, null and bare bundle-name fallbacks remain unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant