Skip to content

ci(clawhub): skip openclaw's install scripts so the publish runs on Node 22 - #38

Merged
omarshahine merged 2 commits into
mainfrom
ci/clawhub-ignore-scripts
Oct 10, 2026
Merged

omarshahine merged 2 commits into
mainfrom
ci/clawhub-ignore-scripts

Conversation

@omarshahine

Copy link
Copy Markdown
Owner

The v0.4.0 ClawHub publish failed at npm install: the openclaw devDependency's preinstall now exits on Node < 24.16, and this workflow runs Node 22 (run 38061299322). The build here is only tsc, so declining install scripts is enough; it avoids raising the Node version that the ClawHub validator runs on. v0.4.0 itself is being published to ClawHub from a clean checkout of the tag with the same steps.

🤖 Generated with Claude Code

…ode 22

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[High impact] Changes the build setup for the publish workflow.

The PR appears safe to merge, with a non-blocking correction to the build explanation.

Fix All in Claude CodeFindings

  1. P2 Comment names wrong build tool ▶
Fix with agent prompt
### Issue 1
.github/workflows/publish-clawhub.yml:51-52
The new comment says the build uses only `tsc`, but `npm run build` runs `tsup`, which depends on `esbuild` and `rollup`. This gives future maintainers the wrong reason for why skipping install scripts is safe. Name `tsup` and explain that its platform binaries arrive through optional packages.

```suggestion
      # Node < 24.16. The build uses tsup; its esbuild and rollup binaries
      # arrive through optional packages without needing install scripts.
      # v0.4.0's ClawHub publish failed on exactly this.
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The ClawHub workflow adds --ignore-scripts to skip dependency install scripts while keeping Node 22.

  • ClawHub publishing installs dependencies without running their scripts.

Reviews (1) · Last reviewed commit: "ci(clawhub): skip openclaw's install scr..." · Reviewed by Greptile

Comment thread .github/workflows/publish-clawhub.yml Outdated
Comment on lines +51 to +52
# Node < 24.16, and the build here is only tsc, which needs none of
# its install scripts. v0.4.0's ClawHub publish failed on exactly this.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Comment names wrong build tool

The new comment says the build uses only tsc, but npm run build runs tsup, which depends on esbuild and rollup. This gives future maintainers the wrong reason for why skipping install scripts is safe. Name tsup and explain that its platform binaries arrive through optional packages.

Suggested change
# Node < 24.16, and the build here is only tsc, which needs none of
# its install scripts. v0.4.0's ClawHub publish failed on exactly this.
# Node < 24.16. The build uses tsup; its esbuild and rollup binaries
# arrive through optional packages without needing install scripts.
# v0.4.0's ClawHub publish failed on exactly this.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/publish-clawhub.yml
Line: 51-52

Comment:
**Comment names wrong build tool**

The new comment says the build uses only `tsc`, but `npm run build` runs `tsup`, which depends on `esbuild` and `rollup`. This gives future maintainers the wrong reason for why skipping install scripts is safe. Name `tsup` and explain that its platform binaries arrive through optional packages.

```suggestion
      # Node < 24.16. The build uses tsup; its esbuild and rollup binaries
      # arrive through optional packages without needing install scripts.
      # v0.4.0's ClawHub publish failed on exactly this.
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's tsup. Fixed the comment. The reasoning still holds: v0.4.0 was published to ClawHub from a clean checkout of the tag with npm install --force --ignore-scripts && npm run build, which produced dist/index.js.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@omarshahine

Copy link
Copy Markdown
Owner Author

Proof: the failing step was openclaw's preinstall (run 38061299322, Node 22). --ignore-scripts skips preinstall regardless of Node version. The same install and build were run from a clean checkout of v0.4.0 and produced dist/, and that build is what's live on ClawHub as findmy-cli 0.4.0 (scan clean). Greptile's P2 (tsup, not tsc) is fixed. CI is green. This changes only a workflow, with no runtime code.

@omarshahine
omarshahine merged commit 04ec970 into main Oct 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant