Repository navigation
ci(clawhub): skip openclaw's install scripts so the publish runs on Node 22 - #38
Conversation
…ode 22 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
| # Node < 24.16, and the build here is only tsc, which needs none of | ||
| # its install scripts. v0.4.0's ClawHub publish failed on exactly this. |
There was a problem hiding this comment.
Comment names wrong build tool
The new comment says the build uses only tsc, but npm run build runs tsup, which depends on esbuild and rollup. This gives future maintainers the wrong reason for why skipping install scripts is safe. Name tsup and explain that its platform binaries arrive through optional packages.
| # Node < 24.16, and the build here is only tsc, which needs none of | |
| # its install scripts. v0.4.0's ClawHub publish failed on exactly this. | |
| # Node < 24.16. The build uses tsup; its esbuild and rollup binaries | |
| # arrive through optional packages without needing install scripts. | |
| # v0.4.0's ClawHub publish failed on exactly this. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/publish-clawhub.yml
Line: 51-52
Comment:
**Comment names wrong build tool**
The new comment says the build uses only `tsc`, but `npm run build` runs `tsup`, which depends on `esbuild` and `rollup`. This gives future maintainers the wrong reason for why skipping install scripts is safe. Name `tsup` and explain that its platform binaries arrive through optional packages.
```suggestion
# Node < 24.16. The build uses tsup; its esbuild and rollup binaries
# arrive through optional packages without needing install scripts.
# v0.4.0's ClawHub publish failed on exactly this.
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
Right, it's tsup. Fixed the comment. The reasoning still holds: v0.4.0 was published to ClawHub from a clean checkout of the tag with npm install --force --ignore-scripts && npm run build, which produced dist/index.js.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Proof: the failing step was openclaw's preinstall (run 38061299322, Node 22). |
The v0.4.0 ClawHub publish failed at
npm install: theopenclawdevDependency's preinstall now exits on Node < 24.16, and this workflow runs Node 22 (run 38061299322). The build here is onlytsc, so declining install scripts is enough; it avoids raising the Node version that the ClawHub validator runs on. v0.4.0 itself is being published to ClawHub from a clean checkout of the tag with the same steps.🤖 Generated with Claude Code