Conversation
With ~/.config/omarchy/branding/screensaver.txt missing, ttfx exited on the spot, the poll loop keyed on a live ttfx never ran, and the outer loop relaunched it as fast as the terminal could print the error: a full-CPU, unclosable fullscreen window that only Ctrl+C could end. Fall back to the stock wordmark when the user's branding is unreadable, track ttfx by pid rather than by tty, and end the screensaver when ttfx fails to start instead of respawning it. Fixes omacom#11090 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LKJ7WaM8LCBtL91KJe3wQT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
~/.config/omarchy/branding/screensaver.txtmissing, ttfx exited on the spot, the poll loop keyed on a live ttfx never ran, and the outer loop relaunched it as fast as the terminal could print the error: a full-CPU, unclosable fullscreen window that only Ctrl+C could end.Fall back to the stock wordmark when the user's branding is unreadable, track ttfx by pid rather than by tty, and end the screensaver when ttfx fails to start instead of respawning it.
Fixes #11090
Testing
New
test/shell.d/screensaver-test.shcovers the fallback, the user-branding path, and that a failing ttfx is launched exactly once. Also ran both scripts under real ttfx in a pty with the branding file missing and a keypress after 1.5 s: the original never exits (355 relaunches in 6 s), the new one exits 0 on the keypress.🤖 Generated with Claude Code
https://claude.ai/code/session_01LKJ7WaM8LCBtL91KJe3wQT