Add single-source split/delete timeline editing - #9
Open
brunomendonca-com wants to merge 1 commit into
Open
brunomendonca-com wants to merge 1 commit into
brunomendonca-com wants to merge 1 commit into
Conversation
brunomendonca-com
force-pushed
the
feature/split-delete-editing
branch
from
September 10, 2026 03:08
b7ad2f1 to
14dc9d2
Compare
brunomendonca-com
marked this pull request as ready for review
September 10, 2026 03:19
|
you should include a demo with this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add single-source, non-destructive split/delete editing while keeping export as one MP4:
The implementation includes a testable clip model, whole-timeline dirty-state tracking, export snapshots, and file-dialog guards/cancellation handling. Multi-range export belongs with split editing because independently resizing split clips can already create gaps.
Scope / draft status
This is a proposal to extend the current single-range trimmer. Keeping it draft for feedback on whether single-source multi-clip editing fits Omacut's scope, and for further desktop/media validation.
No undo, reordering, transitions, multiple source files, or project persistence. Preview uses source seeks and is not guaranteed seamless across cuts. The timeline currently uses a representative thumbnail per clip.
Validation
On the standalone branch:
QT_QPA_PLATFORM=offscreen ./bin/test: 36 backend/UI/export + 11 clip-model passes, including QtTest initialization/cleanup../bin/build: successful.git diff --check: clean.Tests cover split/resize/delete boundaries, both deletion keys and buttons, independent handle dragging, actual preview jumps over removed material, export snapshot isolation, invalid ranges, final-clip reset/reloading, and synthetic color-sequence exports verifying duration/order with and without audio.
Remaining validation: interactive desktop testing, frame-rate variations, unusual audio offsets/synchronization at cuts, and more real-world exports. A desktop-platform run of the combined development branch failed the right-handle mouse-drag test while offscreen passed; that discrepancy still needs investigation. Existing scale-argument tests pass, but broader multi-range scaling integration coverage is still needed.
Independence
This PR targets upstream
masterdirectly and has no dependency on an unmerged PR. Number-key seeking is deliberately excluded and proposed separately against the existing upstream trim API. If that proposal merges first, this PR will adapt it to retained timeline time during integration.