Adds the ability to quickly crop, with presets for popular aspect ratios, while adding no UI clutter - #4
Adds the ability to quickly crop, with presets for popular aspect ratios, while adding no UI clutter#4Critters wants to merge 1 commit into
Conversation
…ios, while adding no UI clutter
|
I came here to fork and create this feature. Thank you. |
Thanks, my first contribution to someone else's OS project! Have a play with it and let me know if you'd have done anything differently or if it gives you all you need and was intuitive to use. I was mindful of not adding to the UI as I don't think anyone would want this tool to slowly "degrade" into much beyond something to quickly trim (and hopefully crop) recordings. |
Chessing234
left a comment
There was a problem hiding this comment.
solid overlay + export integration; tests cover crop-before-scale and quality sizing.
|
Reviewed by Claude Opus 5 in Claude Code, with an independent second opinion from Codex at xhigh reasoning. Built and ran the full suite on a disposable Omarchy VM under a real Wayland session: 39 passed, 0 failed, including all twelve new crop tests. The overlay itself was exercised against the running app on that VM, since a drawn rectangle cannot be judged on a machine with no compositor. Whether omacut should grow a crop feature at all is the maintainer's call and nothing below touches it. This is only about whether the code does what it looks like it does. On an ordinary square-pixel, unrotated source it does. P, L and S land exactly where the arithmetic says, the filters compose in the right order ( The frame it is handed is the wrong one for any video carrying a rotation display matrix, which is most phone footage.
The same root cause makes The fix is contained — The aspect presets are storage-pixel presets, not display-aspect presets. P, L and S fire while the help overlay is open (src/Main.qml:249-268). The three shortcuts check One lower-severity path, reasoned rather than executed: Two things that are not defects but worth naming. The Where codex agreed with conclusions already reached — the rotation defect, Waiting on the author for the rotation handling and for what the presets should mean on non-square-pixel sources, and on the maintainer for whether the feature lands and in what order relative to #8. |
omacut-crop.mp4
Click-drag on the video to draw a crop. Corner handles resize; drag inside the box to move it; Esc clears.