Skip to content

Fail the camera check when frames go missing - #47

Open
arjenbloemsma wants to merge 2 commits into
omacom:masterfrom
arjenbloemsma:camera-check-frame-count
Open

arjenbloemsma wants to merge 2 commits into
omacom:masterfrom
arjenbloemsma:camera-check-frame-count

Conversation

@arjenbloemsma

Copy link
Copy Markdown

bin/test-camera only checks how long the clip plays. A take can play for the right time and still have lost most of its frames: on 0.3.1 my Framework Laptop 13 Pro recorded 2.5 to 5 fps, and this check would have passed it.

The check now counts the frames the camera delivers while recording, through the preview sink, and counts the frames in the clip with ffprobe. It fails when the clip holds fewer than 90% of them. Comparing against the camera, not a fixed rate, keeps it from failing when a camera slows down in low light.

Checked on master with the built-in 1080p webcam: five takes each came within one frame of the camera's count. With a temporary change that dropped two of every three frames in Writer, it reported 40 of 119 and failed.

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The changes appear safe to merge; no new actionable issues were found.

Summary

The camera check now compares saved frames against camera delivery, capped at the take’s actual frame rate.

  • The camera check now fails when a clip loses too many frames.

No new actionable issues found.

Reviews (2) · Last reviewed commit: "Compare against the rate the take is wri..." · Reviewed by Greptile

Comment thread tests/camera_check.cpp Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant