Repository navigation
Fail the camera check when frames go missing - #47
Open
arjenbloemsma wants to merge 2 commits into
Open
arjenbloemsma wants to merge 2 commits into
arjenbloemsma wants to merge 2 commits into
Conversation
[Low impact] The changes appear safe to merge; no new actionable issues were found. SummaryThe camera check now compares saved frames against camera delivery, capped at the take’s actual frame rate.
No new actionable issues found. Reviews (2) · Last reviewed commit: "Compare against the rate the take is wri..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/test-cameraonly checks how long the clip plays. A take can play for the right time and still have lost most of its frames: on 0.3.1 my Framework Laptop 13 Pro recorded 2.5 to 5 fps, and this check would have passed it.The check now counts the frames the camera delivers while recording, through the preview sink, and counts the frames in the clip with ffprobe. It fails when the clip holds fewer than 90% of them. Comparing against the camera, not a fixed rate, keeps it from failing when a camera slows down in low light.
Checked on master with the built-in 1080p webcam: five takes each came within one frame of the camera's count. With a temporary change that dropped two of every three frames in Writer, it reported 40 of 119 and failed.