Repository navigation
Start in a third of a second by probing only CUDA and VA-API - #37
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; no actionable issues were established. SummaryCentralizes Qt FFmpeg setup in
No actionable issues were established. No build or runtime tests were run. Reviews (1) · Last reviewed commit: "Start in a third of a second by probing ..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monologue took more than two seconds to show its window. Qt's FFmpeg backend opens a context for every hardware API it knows (vdpau, CUDA, VA-API, Vulkan) when it first loads. That is 1.9 s on this machine, Vulkan alone 0.8 s, and it all happens in
Backend's constructor before QML even loads.Recording only needs the APIs behind the hardware H.264 encoders: CUDA for NVENC and VA-API for Intel and AMD.
media::useFfmpeg()now sets Qt'sQT_FFMPEG_ENCODING_HW_DEVICE_TYPESandQT_FFMPEG_DECODING_HW_DEVICE_TYPEStocuda,vaapialongside the backend choice, unless they're already set. Qt then skips the up-front probe and checks the device when a recording starts.A real take through
bin/test-camerastill opensh264_nvenc, andh264_vaapiremains the next candidate. The app,camera_check, and both test binaries share the one function, so they all load the backend the same way.🤖 Generated with Claude Code