Repository navigation
Add mirror preview toggle - #22
Closed
mjpythonnewb wants to merge 1 commit into
Closed
mjpythonnewb wants to merge 1 commit into
mjpythonnewb wants to merge 1 commit into
Conversation
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryAdds a saved mirror setting and a flat button outside the editor.
|
mjpythonnewb
force-pushed
the
feature/mirror-and-mute
branch
from
November 8, 2026 00:14
02d798f to
216749d
Compare
mjpythonnewb
force-pushed
the
feature/mirror-and-mute
branch
from
November 8, 2026 20:57
216749d to
8365ed4
Compare
Contributor
Author
|
@greptileai review |
mjpythonnewb
force-pushed
the
feature/mirror-and-mute
branch
from
November 8, 2026 22:04
6f838c7 to
8365ed4
Compare
Contributor
|
Thanks! Your preview-only approach is the one we went with. Your commit is cherry-picked with your authorship into #39, which also turns mirroring on by default, swaps the text button for a small icon at the bottom right, and adds the M key and tests. |
dhh
added a commit
that referenced
this pull request
Nov 12, 2026
* Add mirror preview toggle (preview only, recording stays unmirrored) * Mirror the preview by default, with a quiet toggle and M Builds on mjpythonnewb's preview-only mirror (#22), with the M key from kvm404's #20. The recording itself is never mirrored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Size the mirror toggle in its row, show its tooltip, and match the left inset Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: mjpythonnewb <mj.python@proton.me> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a mirror preview toggle to the recording UI:
Flat button in the bottom-right corner, visible only outside the editor.