Skip to content

Add mirror preview toggle - #22

Closed
mjpythonnewb wants to merge 1 commit into
omacom:masterfrom
mjpythonnewb:feature/mirror-and-mute
Closed

mjpythonnewb wants to merge 1 commit into
omacom:masterfrom
mjpythonnewb:feature/mirror-and-mute

Conversation

@mjpythonnewb

@mjpythonnewb mjpythonnewb commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Adds a mirror preview toggle to the recording UI:

  • Mirror preview toggle: flips the live preview horizontally (recording stays unmirrored so text reads correctly). Persisted in settings.

Flat button in the bottom-right corner, visible only outside the editor.

@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Adds a saved mirror setting and a flat button outside the editor.

  • The recording screen can mirror its live preview without mirroring saved clips.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Button[Mirror button] --> Setting[Saved mirror setting]
  Setting --> Preview[Live preview]
  Camera[Camera frame] --> Preview
  Camera --> Writer[Recording writer]
Loading

Reviews (7) · Last reviewed commit: "Add mirror preview toggle (preview only,..." · Reviewed by Greptile

Comment thread src/backend.cpp Resolved
Comment thread src/Main.qml Resolved
Comment thread src/backend.cpp Resolved
@mjpythonnewb
mjpythonnewb force-pushed the feature/mirror-and-mute branch from 02d798f to 216749d Compare November 8, 2026 00:14
Comment thread src/backend.cpp Resolved
Comment thread src/backend.cpp Resolved
@mjpythonnewb
mjpythonnewb force-pushed the feature/mirror-and-mute branch from 216749d to 8365ed4 Compare November 8, 2026 20:57
@mjpythonnewb mjpythonnewb changed the title Add mirror preview toggle and mute mic button Add mirror preview toggle Nov 8, 2026
@mjpythonnewb

Copy link
Copy Markdown
Contributor Author

@greptileai review

@dhh

dhh commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Thanks! Your preview-only approach is the one we went with. Your commit is cherry-picked with your authorship into #39, which also turns mirroring on by default, swaps the text button for a small icon at the bottom right, and adds the M key and tests.

@dhh dhh closed this Nov 12, 2026
dhh added a commit that referenced this pull request Nov 12, 2026
* Add mirror preview toggle (preview only, recording stays unmirrored)

* Mirror the preview by default, with a quiet toggle and M

Builds on mjpythonnewb's preview-only mirror (#22), with the M key from
kvm404's #20. The recording itself is never mirrored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Size the mirror toggle in its row, show its tooltip, and match the left inset

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: mjpythonnewb <mj.python@proton.me>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants