Skip to content

Add a Mirror toggle that saves takes as you saw them - #20

Closed
kvm404 wants to merge 2 commits into
omacom:masterfrom
kvm404:mirror-preview
Closed

kvm404 wants to merge 2 commits into
omacom:masterfrom
kvm404:mirror-preview

Conversation

@kvm404

@kvm404 kvm404 commented Nov 6, 2026

Copy link
Copy Markdown

Monologue shows the camera's true orientation. Most camera apps (Zoom, Meet, phone front cameras) show a mirrored picture instead, so the preview feels backwards at first: raise your right hand and it moves on the left.

This adds a Mirror toggle, off by default so nothing changes unless you turn it on.

  • Mirror button at the bottom right of the recorder, or press M. The choice is remembered in monologue.conf.
  • Each take keeps the choice it started with. The toggle is disabled during a take, like the camera and microphone pickers.
  • A mirrored take plays mirrored in the editor, filmstrip included, and is flipped with hflip when saved, so the file matches what you saw.
  • Recording itself is unchanged: frames are captured and encoded exactly as before, so there's no extra per-frame work. The flip happens only on export. That means a mirrored take is always re-encoded on save, even when unedited.
  • A .mirrored marker in the take's folder keeps a recovered take mirrored.
  • Added to the ? shortcut list and the README.

Tests

  • mirrorPreviewIsRemembered: off by default, persisted, signals once.
  • mirroredTakeSavesMirrored: an unedited red|blue take recovered with the marker is re-encoded on save and comes out blue|red.
  • editModel: export args with hflip.
  • UI: the button and M toggle the live picture, both are blocked during a take, the button is hidden in the editor, and clip playback flips with takeMirrored.

On my machine (Intel iGPU), realEncoding and the tests that depend on its fixture already fail on master (VAAPI frame count), with or without this change. Everything else passes, including the new tests.

Most camera apps show you a mirrored picture, so Monologue's true-orientation
preview feels backwards when you first use it. Mirror (button or M) flips the
picture. Each take keeps the choice it started with: it plays mirrored in the
editor, filmstrip included, and is flipped with hflip when saved, so the file
matches what you saw. A mirrored take is always re-encoded on save.

The choice is remembered in the settings and is off by default. A marker in
the take's folder keeps a recovered take mirrored.
@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the previous keyboard issue is fixed and no new actionable issues were found.

Summary

Adds a remembered Mirror choice that stays with each take through playback, recovery, and saving.

  • The recorder can mirror the live picture before a take starts.
  • Mirrored takes stay mirrored in the editor and saved video.

Reviews (2) · Last reviewed commit: "Toggle Mirror with Return and Enter when..." · Reviewed by Greptile

Comment thread src/Main.qml Resolved
ActionButton handles Return/Enter by emitting clicked(), which never toggles a checkable button. Mirror now acts on clicked, so mouse, Space, Return and Enter all take the same path, with checked bound to the setting.
@dhh

dhh commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Thanks for the careful work here, including the recovery marker and tests. We decided the recording should stay un-mirrored, as in Zoom and FaceTime, so text in the shot reads correctly for viewers and saves don't have to re-encode. #39 mirrors only the preview, on by default, and uses your M shortcut.

@dhh dhh closed this Nov 12, 2026
dhh added a commit that referenced this pull request Nov 12, 2026
* Add mirror preview toggle (preview only, recording stays unmirrored)

* Mirror the preview by default, with a quiet toggle and M

Builds on mjpythonnewb's preview-only mirror (#22), with the M key from
kvm404's #20. The recording itself is never mirrored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Size the mirror toggle in its row, show its tooltip, and match the left inset

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: mjpythonnewb <mj.python@proton.me>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants