Repository navigation
Conversation
 [Medium impact] The change reaches localized text across the desktop app’s supported languages. The PR appears safe to merge, with a non-blocking correction needed for selected-slide counts. Findings
SummaryFills 49 language catalogs with translated controls, messages, and selected-slide counts.
Reviews (1) · Last reviewed commit: "Update translations" · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "%1 already exists. Choose another name.": "Mayroon na ang %1. Pumili ng ibang pangalan.", | ||
| "%1 — Presenter View": "%1 — View ng Tagapagtanghal", | ||
| "%Ln slides selected": { | ||
| "one": "Isang slide ang napili", |
There was a problem hiding this comment.
The Filipino one form says “One slide is selected,” but pluralCategory selects it for counts such as 2, 3, and 5. The Croatian form in src/i18n/hr.json has the same problem for 21 or 31 slides. Users therefore see one selected slide while several are selected. Keep %Ln in both translations instead of spelling out one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated translation sync: fills pending strings in the 49 language catalogs from src/i18n/en.json. Generated by the Sync translations workflow, which validated these catalogs with the catalog tests and merges this pull request itself.