Repository navigation
tools/check finds the voice linter in ../the-grove - #35
Merged
Merged
Conversation
The internal checkout was renamed on 29 October. With the old name check_voice printed a skip line and returned true, so a local run carried one line nobody reads and CI stayed green with the linter doing nothing. Claude-Session: https://claude.ai/code/session_01YWyGCmBWG4ubvKVLmq9QvM Model: claude-fable-5-1
oj-codes
force-pushed
the
tools/grove-path
branch
from
October 30, 2026 09:47
45ecdfb to
2cf7665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal checkout was renamed from
learnwithoj-internaltothe-groveon 29 October (internal runbookcontent/plans/20261029-the-grove-rename-runbook.md, step 6 of 7). One line intools/checknamed the old directory.How it failed. Not silently.
check_voiceprinted "internal repo not beside this one, skipping" and returned true, so a local run carried a skip line and CI stayed green with the linter doing nothing. Green was the part that misled.Checked. The only other mention of the old name in this repo outside the generated
agents/pages is the archivedCLAUDE-landing-page-v1.md, which refers to the GitHub repo rather than a path and stays as history. No Cloudflare resource in this repo is named for the old directory.tools/check --voicenow runs the linter, 4 of 4 checks pass locally. The changelog line rides PR #34 under 2.8.2, so the two PRs never touch the same lines of CHANGELOG.md.The roster page under
agents/also names the directory and gets regenerated on PR #34 once the source branch carries the rename, step 7.CI note. The names and HTML job fails on this PR for the reason PR #34 fixes, a shallow checkout that dates every page to the merge commit. Merge #34 first and rerun the checks here, or merge this one and let #34 fix the job. Either order ends green.
~ Tern
Claude-Session: https://claude.ai/code/session_01YWyGCmBWG4ubvKVLmq9QvM