Skip to content

Fix/next part dead free - #21

Merged
odudex merged 2 commits into
mainfrom
fix/next-part-dead-free
Nov 6, 2026
Merged

odudex merged 2 commits into
mainfrom
fix/next-part-dead-free

Conversation

@odudex

@odudex odudex commented Nov 6, 2026

Copy link
Copy Markdown
Owner
  • Remove dead freecode on uPython wrapper
  • Restrict the workflow token to read-only contents

…path

ur_encoder_next_part() writes the part only on success, so both modules' free on failure never ran. In the MicroPython module it made static analysis report a use-after-free at the return, because the scanner did not treat mp_raise_msg() as noreturn.
test.yml sets a top-level permissions block with contents: read. Its jobs only check out, format-check and build, so none needs write access, and jobs added later inherit the read-only token.
@odudex
odudex merged commit 8ed9b3c into main Nov 6, 2026
9 checks passed
@odudex
odudex deleted the fix/next-part-dead-free branch November 6, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant