Skip to content

fix(psbt): sign a taptree input with every key the coordinator lists, refuse two keys on one path - #217

Draft
pythcoiner wants to merge 1 commit into
odudex:masterfrom
pythcoiner:taptree_signing
Draft

pythcoiner wants to merge 1 commit into
odudex:masterfrom
pythcoiner:taptree_signing

Conversation

@pythcoiner

@pythcoiner pythcoiner commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Bump libwally to add "psbt: reject key-path signing with a non-internal key" and "psbt: do not gate script-path signing on the key-path lookup" on top of 501b204e. Without the latter, an input whose key path is already signed gets no leaf signature: libwally stops looking up the taproot leaf keys once PSBT_IN_TAP_KEY_SIG is present.

An input whose PSBT_IN_TAP_BIP32_DERIVATION entries name two keys on one of our derivation paths refuses the whole PSBT before anything is signed.

This PR requires 2 commits to be ported on out libwally fork:

… refuse two keys on one path

Bump libwally to add "psbt: reject key-path signing with a non-internal
key" and "psbt: do not gate script-path signing on the key-path lookup"
on top of 501b204e. Without the latter, an input whose key path is
already signed gets no leaf signature: libwally stops looking up the
taproot leaf keys once PSBT_IN_TAP_KEY_SIG is present.

An input whose PSBT_IN_TAP_BIP32_DERIVATION entries name two keys on one
of our derivation paths refuses the whole PSBT before anything is signed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant