Repository navigation
fix(psbt): sign a taptree input with every key the coordinator lists, refuse two keys on one path - #217
Draft
pythcoiner wants to merge 1 commit into
Draft
fix(psbt): sign a taptree input with every key the coordinator lists, refuse two keys on one path#217pythcoiner wants to merge 1 commit into
pythcoiner wants to merge 1 commit into
Conversation
… refuse two keys on one path Bump libwally to add "psbt: reject key-path signing with a non-internal key" and "psbt: do not gate script-path signing on the key-path lookup" on top of 501b204e. Without the latter, an input whose key path is already signed gets no leaf signature: libwally stops looking up the taproot leaf keys once PSBT_IN_TAP_KEY_SIG is present. An input whose PSBT_IN_TAP_BIP32_DERIVATION entries name two keys on one of our derivation paths refuses the whole PSBT before anything is signed.
10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump libwally to add "psbt: reject key-path signing with a non-internal key" and "psbt: do not gate script-path signing on the key-path lookup" on top of 501b204e. Without the latter, an input whose key path is already signed gets no leaf signature: libwally stops looking up the taproot leaf keys once PSBT_IN_TAP_KEY_SIG is present.
An input whose PSBT_IN_TAP_BIP32_DERIVATION entries name two keys on one of our derivation paths refuses the whole PSBT before anything is signed.
This PR requires 2 commits to be ported on out libwally fork:
pythcoiner/libwally-core@23727ad
pythcoiner/libwally-core@9098777