Repository navigation
Fix/bip138 liana interop - #202
Merged
Merged
Conversation
The loader read every file as text, so a binary BIP138 container, as Liana exports it, was cut at its first zero byte and reported as an unrecognized format.
BIP138 names the raw binary .bip138 and the base64 text .txt, and Liana writes .bip138. Existing .bip138.txt files are still read as base64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better handle and prioritizes BIP138 binary format (.bip138) instead of base64 encoded (.bip138.txt) in SD card load and export.