Skip to content

fix(simulator): build on macOS - #198

Closed
subinita01 wants to merge 2 commits into
odudex:masterfrom
subinita01:fix/simulator-macos-build
Closed

subinita01 wants to merge 2 commits into
odudex:masterfrom
subinita01:fix/simulator-macos-build

Conversation

@subinita01

@subinita01 subinita01 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Builds the simulator on macOS (Homebrew).

  • find_package(SDL2) already ran, but its include and library variables weren't used, so Homebrew's SDL2 headers and library were never found.
  • bf92add selected explicit_bzero, which macOS libc lacks. Apple builds now use memset_s, which libwally already supports as a non-elidable wipe. On RISC-V (firmware) and Linux the effective config.h is unchanged.

Tested on macOS (Apple clang): clean simulator build with no extra flags, ctest passes, and the host tests' libwally now builds there too. Not tested on Linux.

@subinita01
subinita01 force-pushed the fix/simulator-macos-build branch from e596304 to bec159a Compare October 14, 2026 06:06
@odudex odudex mentioned this pull request Nov 6, 2026
@odudex

odudex commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Thank you for the fixes @subinita01 . I rebased and picked the first commit of your PR.
I replaced the second commit with an alternative fix, since simulator/Mac/Linux related code should live on simulator/ folder only.

@odudex odudex closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants